fix(subject_imperative): mixed definitions

StaticRocket · shenxianpeng · commit bcbe2015b92c · 2025-12-15T11:59:01.000+02:00
Following the documentation the old imperative check was renamed to subject_imperative. Replace all old definitions with the new name to match documented behavior. Fixes: 9f90bbd ("feat: Breaking Changes & Configuration Migration (v2 version) (#280)") Signed-off-by: Randolph Sapp <rs@ti.com>
diff --git a/commit_check/engine.py b/commit_check/engine.py
@@ -522,7 +522,7 @@ class ValidationEngine:
     VALIDATOR_MAP: Dict[str, Type[BaseValidator]] = {
         "message": CommitMessageValidator,
         "subject_capitalized": SubjectCapitalizationValidator,
-        "imperative": SubjectImperativeValidator,
+        "subject_imperative": SubjectImperativeValidator,
         "subject_max_length": SubjectLengthValidator,
         "subject_min_length": SubjectLengthValidator,
         "author_name": AuthorValidator,
diff --git a/commit_check/main.py b/commit_check/main.py
@@ -151,7 +151,7 @@ def main() -> int:
             requested_checks.extend(
                 [
                     "message",
-                    "imperative",
+                    "subject_imperative",
                     "subject_max_length",
                     "subject_min_length",
                     "require_signed_off_by",
diff --git a/commit_check/rules_catalog.py b/commit_check/rules_catalog.py
@@ -27,7 +27,7 @@ class RuleCatalogEntry:
         suggest="Capitalize the first word of the subject",
     ),
     RuleCatalogEntry(
-        check="imperative",
+        check="subject_imperative",
         regex=None,
         error="Commit message should use imperative mood (e.g., 'Add feature' not 'Added feature')",
         suggest="Use imperative mood in the subject line",
diff --git a/tests/engine_comprehensive_test.py b/tests/engine_comprehensive_test.py
@@ -157,7 +157,7 @@ class TestSubjectImperativeValidator:
     def test_subject_imperative_pass(self):
         """Test SubjectImperativeValidator pass case."""
         rule = ValidationRule(
-            check="imperative",
+            check="subject_imperative",
             regex="",
             error="Subject must be imperative",
             suggest="Use imperative mood",
@@ -173,7 +173,7 @@ def test_subject_imperative_pass(self):
     def test_subject_imperative_fail(self):
         """Test SubjectImperativeValidator fail case."""
         rule = ValidationRule(
-            check="imperative",
+            check="subject_imperative",
             regex="",
             error="Subject must be imperative",
             suggest="Use imperative mood",
@@ -247,7 +247,7 @@ def test_validation_engine_validator_map(self):
         expected_mappings = {
             "message": CommitMessageValidator,
             "subject_capitalized": SubjectCapitalizationValidator,
-            "imperative": SubjectImperativeValidator,
+            "subject_imperative": SubjectImperativeValidator,
             "subject_max_length": SubjectLengthValidator,
             "subject_min_length": SubjectLengthValidator,
             "author_name": AuthorValidator,
diff --git a/tests/engine_test.py b/tests/engine_test.py
@@ -811,7 +811,7 @@ class TestSubjectImperativeValidator:
     @pytest.mark.benchmark
     def test_validate_with_imperative_subject(self):
         """Test validation with proper imperative subject."""
-        rule = ValidationRule(check="imperative")
+        rule = ValidationRule(check="subject_imperative")
         validator = SubjectImperativeValidator(rule)
         context = ValidationContext(stdin_text="fix: resolve the issue")
 
@@ -821,7 +821,7 @@ def test_validate_with_imperative_subject(self):
     @pytest.mark.benchmark
     def test_validate_with_non_imperative_subject(self):
         """Test validation with non-imperative subject."""
-        rule = ValidationRule(check="imperative")
+        rule = ValidationRule(check="subject_imperative")
         validator = SubjectImperativeValidator(rule)
         context = ValidationContext(stdin_text="fix: resolved the issue")
 
@@ -833,7 +833,7 @@ def test_validate_with_non_imperative_subject(self):
     @pytest.mark.benchmark
     def test_validate_short_subject(self):
         """Test validation with very short subject (edge case)."""
-        rule = ValidationRule(check="imperative")
+        rule = ValidationRule(check="subject_imperative")
         validator = SubjectImperativeValidator(rule)
         context = ValidationContext(stdin_text="feat: add")
 
@@ -844,7 +844,7 @@ def test_validate_short_subject(self):
     @pytest.mark.benchmark
     def test_validate_with_breaking_change(self):
         """Test validation with breaking change notation."""
-        rule = ValidationRule(check="imperative")
+        rule = ValidationRule(check="subject_imperative")
         validator = SubjectImperativeValidator(rule)
         context = ValidationContext(stdin_text="feat!: update authentication system")
 
@@ -855,7 +855,7 @@ def test_validate_with_breaking_change(self):
     @pytest.mark.benchmark
     def test_validate_with_scoped_breaking_change(self):
         """Test validation with scoped breaking change notation."""
-        rule = ValidationRule(check="imperative")
+        rule = ValidationRule(check="subject_imperative")
         validator = SubjectImperativeValidator(rule)
         context = ValidationContext(stdin_text="fix(auth)!: resolve login bug")
 

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ def main() -> int:`
`151`	`151`	`requested_checks.extend(`
`152`	`152`	`[`
`153`	`153`	`"message",`
`154`		`- "imperative",`
	`154`	`+ "subject_imperative",`
`155`	`155`	`"subject_max_length",`
`156`	`156`	`"subject_min_length",`
`157`	`157`	`"require_signed_off_by",`