[Refactor] Remove Temporal::Concerns::Payloads#314
Merged
cj-cb merged 12 commits intocoinbase:masterfrom Sep 4, 2024
Merged
Conversation
Contributor
Author
|
Here's the fix for the failing integration specs — #315 |
|
@antstorm there are some fails on the test_examples fyi! |
Contributor
Author
cj-cb
approved these changes
Sep 3, 2024
antstorm
force-pushed
the
fix-config-deprecation-2
branch
from
12c5fee to
06012f5
Compare
Contributor
Author
|
@cj-cb rebased with master without any changes, this should now be good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a resurrection of #152, that got too far behind the
HEAD.This is the first (but definitely the biggest by far) step to resolving #143. Since the introduction of
Temporal::Concerns::Payloadseverything that was using it was dependent on the primary singleton configuration. This means that you can't have 2 clients or workers within the same app that are using different configs. The solution is explicitly injectable configuration.This PR introduces
Temporal::ConverterWrapperthat has all the functionality of theTemporal::Concerns::Payloads, but is meant to be provided explicitly to the parts of the code that need it. This way there are no hidden dependencies on the global configuration.Once this is merged, a small number of references to
Temporal.configurationwill need to be removed and the deprecation warning should go away for good.