Added list_namespace to client and fixed gRPC request#137
Merged
antstorm merged 5 commits intocoinbase:masterfrom Feb 14, 2022
Merged
Added list_namespace to client and fixed gRPC request#137antstorm merged 5 commits intocoinbase:masterfrom
antstorm merged 5 commits intocoinbase:masterfrom
Conversation
antstorm
suggested changes
Feb 9, 2022
Contributor
antstorm
left a comment
antstorm
left a comment
There was a problem hiding this comment.
Hey @calum-stripe !
The change looks good, that you for contributing! A couple of things to consider:
- Can you please add a unit test (in addition to the integration test)?
- I wonder if it makes sense to allow the caller to specify a page size without the offset? Otherwise there's no way to get to results beyond your page size without increasing it
- I wonder if we should start wrapping responses from gRPC in order to prevent proto exposure to the users of the SDK. I know that other methods might have the same issue, so it's optional as far as this PR is concerned
Contributor
Author
|
Hey @antstorm! 👋
Added :)
Woops overlooked this... you're right! Added
Interesting point, not sure how you track work like this that needs to be done but feel free to add it there! |
antstorm
approved these changes
Feb 11, 2022
Contributor
antstorm
left a comment
antstorm
left a comment
There was a problem hiding this comment.
Looks great, thank you for making the final changes. One last nit and we're good to go
lib/temporal/client.rb
Outdated
| # Fetches all the namespaces. | ||
| # | ||
| # @param page_size [Integer] number of namespace results to return per page. | ||
| # @param next_page_token [String] page token to advancing the pagination (provide this ) |
Contributor
There was a problem hiding this comment.
Nit: this comment looks unfinished, maybe something like "a optional pagination token returned by a previous list_namespaces call"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list_namespacewas broken because of this PR merged into the Protos repo. This fixes this and also exposeslist_namespacesas a function on the client (we're wanting to use this functionality at Stripe)