Modify the Getting Started section so that it works#131
Merged
DeRauk merged 1 commit intocoinbase:masterfrom Jan 21, 2022
Merged
Modify the Getting Started section so that it works#131DeRauk merged 1 commit intocoinbase:masterfrom
DeRauk merged 1 commit intocoinbase:masterfrom
Conversation
- removed metacharacters from the shell commands so they can be copy/pasted directly - added require 'temporal-ruby' for each example that needs it - made it clear that the worker and workflow both need access to the same configuration step, so it should be its own file - made it clear the worker and workflow files need to be executed in their own terminals/shells
DeRauk
approved these changes
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed metacharacters from the shell commands so they can be
copy/pasted directly
added require 'temporal-ruby' for each example that needs it
made it clear that the worker and workflow both need access to
the same configuration step, so it should be its own file
made it clear the worker and workflow files need to be executed
in their own terminals/shells