codingwangfeng
diff --git a/‎.travis.yml‎
Lines changed: 2 additions & 0 deletions b/‎.travis.yml‎
Lines changed: 2 additions & 0 deletions
diff --git a/‎alchemy/build.gradle‎
Lines changed: 1 addition & 0 deletions b/‎alchemy/build.gradle‎
Lines changed: 1 addition & 0 deletions
diff --git a/‎build.gradle‎
Lines changed: 18 additions & 1 deletion b/‎build.gradle‎
Lines changed: 18 additions & 1 deletion
diff --git a/‎conversation/build.gradle‎
Lines changed: 1 addition & 0 deletions b/‎conversation/build.gradle‎
Lines changed: 1 addition & 0 deletions
diff --git a/‎core/build.gradle‎
Lines changed: 1 addition & 4 deletions b/‎core/build.gradle‎
Lines changed: 1 addition & 4 deletions
diff --git a/‎core/src/main/java/com/ibm/watson/developer_cloud/service/WatsonService.java‎
Lines changed: 1 addition & 1 deletion b/‎core/src/main/java/com/ibm/watson/developer_cloud/service/WatsonService.java‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎core/src/test/java/com/ibm/watson/developer_cloud/util/WaitFor.java‎
Lines changed: 3 additions & 1 deletion b/‎core/src/test/java/com/ibm/watson/developer_cloud/util/WaitFor.java‎
Lines changed: 3 additions & 1 deletion
diff --git a/‎dialog/build.gradle‎
Lines changed: 1 addition & 3 deletions b/‎dialog/build.gradle‎
Lines changed: 1 addition & 3 deletions
diff --git a/‎discovery/build.gradle‎
Lines changed: 2 additions & 2 deletions b/‎discovery/build.gradle‎
Lines changed: 2 additions & 2 deletions
diff --git a/‎discovery/src/main/java/com/ibm/watson/developer_cloud/discovery/v1/Discovery.java‎
Lines changed: 0 additions & 1 deletion b/‎discovery/src/main/java/com/ibm/watson/developer_cloud/discovery/v1/Discovery.java‎
Lines changed: 0 additions & 1 deletion
@@ -34,6 +34,8 @@ script:
   - ./gradlew test
   - ./gradlew codeCoverageReport
   - ./gradlew docs > /dev/null # build the javadoc
+  - ./gradlew checkstyleMain
+  - ./gradlew checkstyleTest
 
 after_success:
   - bash <(curl -s https://codecov.io/bash)
 
@@ -51,6 +51,7 @@ signArchives {
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {
 
@@ -17,6 +17,19 @@ javadoc {
   source = 'src/main/java'
 }
 
+checkstyle {
+  ignoreFailures = false
+}
+
+checkstyleMain {
+  ignoreFailures = false
+}
+
+checkstyleTest {
+  ignoreFailures = false
+}
+
+
 task docs(type: Javadoc) {
   destinationDir = file("$buildDir/docs/all")
 }
@@ -45,8 +58,12 @@ allprojects {
 
 subprojects {
 
+  checkstyleMain {
+    ignoreFailures = false
+  }
+
   checkstyleTest {
-    ignoreFailures = true
+    ignoreFailures = false
   }
 
   afterEvaluate {
 
@@ -51,6 +51,7 @@ signArchives {
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 dependencies {
 
@@ -49,13 +49,10 @@ signArchives {
     }
 }
 
-checkstyleTest {
-    ignoreFailures = true
-}
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
-    ignoreFailures = true
+    ignoreFailures = false
 }
 
   task testJar(type: Jar) {
 
@@ -134,7 +134,7 @@ protected OkHttpClient configureHttpClient() {
         .build();
 
     builder.connectionSpecs(Arrays.asList(spec, ConnectionSpec.CLEARTEXT));
-    
+
     return builder.build();
   }
 
 
@@ -21,7 +21,9 @@
 
 public class WaitFor {
 
-  private WaitFor() {}
+  private WaitFor() {
+
+  }
 
   /**
    * Static method used to wait for a specific condition to be satisfied.
 
@@ -49,11 +49,9 @@ signArchives {
     }
 }
 
-checkstyleTest {
-    ignoreFailures = true
-}
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
+    ignoreFailures = false
 }
 
 task testJar(type: Jar) {
 
@@ -50,12 +50,12 @@ signArchives {
 }
 
 checkstyleTest {
-    ignoreFailures = true
+    ignoreFailures = false
 }
 
 checkstyle {
     configFile = rootProject.file('checkstyle.xml')
-    ignoreFailures = true
+    ignoreFailures = false
 }
 
 dependencies {
 
@@ -356,7 +356,6 @@ public ServiceCall<CreateDocumentResponse> createDocument(CreateDocumentRequest
         }
         Validator.notNull(createRequest.getFile(), "Document " + FILE + " cannot be null");
         MediaType mediaType = supportedMediaTypes.get(createRequest.getMediaType());
-        Validator.notNull(mediaType, String.format("Media Type '%s' not supported", createRequest.getMediaType()));
         RequestBody file = InputStreamRequestBody.create(mediaType, createRequest.getFile());
         MultipartBody.Builder multipartBuilder = new MultipartBody.Builder();
         multipartBuilder.setType(MultipartBody.FORM);
Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,7 @@ signArchives {`
`51`	`51`
`52`	`52`	`checkstyle {`
`53`	`53`	`configFile = rootProject.file('checkstyle.xml')`
	`54`	`+ ignoreFailures = false`
`54`	`55`	`}`
`55`	`56`
`56`	`57`	`dependencies {`
Original file line number	Diff line number	Diff line change
`@@ -49,13 +49,10 @@ signArchives {`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`
`52`		`-checkstyleTest {`
`53`		`- ignoreFailures = true`
`54`		`-}`
`55`	`52`
`56`	`53`	`checkstyle {`
`57`	`54`	`configFile = rootProject.file('checkstyle.xml')`
`58`		`- ignoreFailures = true`
	`55`	`+ ignoreFailures = false`
`59`	`56`	`}`
`60`	`57`
`61`	`58`	`task testJar(type: Jar) {`
Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ protected OkHttpClient configureHttpClient() {`
`134`	`134`	`.build();`
`135`	`135`
`136`	`136`	`builder.connectionSpecs(Arrays.asList(spec, ConnectionSpec.CLEARTEXT));`
`137`		`-`
	`137`	`+`
`138`	`138`	`return builder.build();`
`139`	`139`	`}`
`140`	`140`
Original file line number	Diff line number	Diff line change
`@@ -49,11 +49,9 @@ signArchives {`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`
`52`		`-checkstyleTest {`
`53`		`- ignoreFailures = true`
`54`		`-}`
`55`	`52`	`checkstyle {`
`56`	`53`	`configFile = rootProject.file('checkstyle.xml')`
	`54`	`+ ignoreFailures = false`
`57`	`55`	`}`
`58`	`56`
`59`	`57`	`task testJar(type: Jar) {`
Original file line number	Diff line number	Diff line change
`@@ -50,12 +50,12 @@ signArchives {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`checkstyleTest {`
`53`		`- ignoreFailures = true`
	`53`	`+ ignoreFailures = false`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`checkstyle {`
`57`	`57`	`configFile = rootProject.file('checkstyle.xml')`
`58`		`- ignoreFailures = true`
	`58`	`+ ignoreFailures = false`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`dependencies {`
Original file line number	Diff line number	Diff line change
`@@ -356,7 +356,6 @@ public ServiceCall<CreateDocumentResponse> createDocument(CreateDocumentRequest`
`356`	`356`	`}`
`357`	`357`	`Validator.notNull(createRequest.getFile(), "Document " + FILE + " cannot be null");`
`358`	`358`	`MediaType mediaType = supportedMediaTypes.get(createRequest.getMediaType());`
`359`		`- Validator.notNull(mediaType, String.format("Media Type '%s' not supported", createRequest.getMediaType()));`
`360`	`359`	`RequestBody file = InputStreamRequestBody.create(mediaType, createRequest.getFile());`
`361`	`360`	`MultipartBody.Builder multipartBuilder = new MultipartBody.Builder();`
`362`	`361`	`multipartBuilder.setType(MultipartBody.FORM);`