Added base exception class NoSQLMapException inside exception.py.#99
Merged
codingo merged 1 commit intocodingo:masterfrom Apr 9, 2020
Merged
Added base exception class NoSQLMapException inside exception.py.#99codingo merged 1 commit intocodingo:masterfrom
codingo merged 1 commit intocodingo:masterfrom
Conversation
codingo
approved these changes
Apr 9, 2020
Owner
|
Excellent work, thank-you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not quite sure if you had intended for the exception class to actually do anything yet, so I created
NoSQLMapExceptionand just left the class empty. I fixed any genericexceptstatements in the other files to use the new base exception but didn't otherwise change any behavior.Is this what you had in mind?
Also worth mentioning were functions in
nsmcouch.pyandnsmmongo.pythat looked like they were missing some arguments. I hadn't set out to fix those, but figured it was easy enough since PyCharm was yelling at me.