Skip to content

Commit 5e4283d

Browse files
committed
Don't request Dev Tools data in Options page
1 parent 19dcd1f commit 5e4283d

2 files changed

Lines changed: 9 additions & 16 deletions

File tree

src/ui/options/body/body.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {m} from 'malevic';
22
import {getContext} from 'malevic/dom';
3-
import type {DevToolsData, ViewProps} from '../../../definitions';
3+
import type {ViewProps} from '../../../definitions';
44
import {Overlay} from '../../controls';
55
import {ListIcon, WatchIcon} from '../../icons';
66
import {AboutTab} from '../about/about-tab';
@@ -10,9 +10,7 @@ import {GeneralTab} from '../general/general-tab';
1010
import {SiteListTab} from '../site-list/site-list-tab';
1111
import TabPanel from '../tab-panel/tab-panel';
1212

13-
type BodyProps = ViewProps & {
14-
devtools: DevToolsData;
15-
};
13+
type BodyProps = ViewProps;
1614

1715
export default function Body(props: BodyProps): Malevic.Child {
1816
const context = getContext();

src/ui/options/index.tsx

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,24 @@
11
import {m} from 'malevic';
22
import {sync} from 'malevic/dom';
3-
import type {DevToolsData, ExtensionData, DebugMessageBGtoCS, DebugMessageBGtoUI} from '../../definitions';
3+
import type {ExtensionData, DebugMessageBGtoCS, DebugMessageBGtoUI} from '../../definitions';
44
import {DebugMessageTypeBGtoUI} from '../../utils/message';
55
import Body from './body/body';
66
import Connector from '../connect/connector';
77

88
declare const __CHROMIUM_MV3__: boolean;
99

10-
function renderBody(data: ExtensionData, devToolsData: DevToolsData, actions: Connector) {
11-
sync(document.body, <Body data={data} devtools={devToolsData} actions={actions} />);
10+
function renderBody(data: ExtensionData, actions: Connector) {
11+
sync(document.body, <Body data={data} actions={actions} />);
1212
}
1313

1414
async function start(): Promise<void> {
1515
const connector = new Connector();
1616
window.addEventListener('unload', () => connector.disconnect(), {passive: true});
1717

18-
let [data, devToolsData] = await Promise.all([
19-
connector.getData(),
20-
connector.getDevToolsData(),
21-
]);
22-
renderBody(data, devToolsData, connector);
23-
connector.subscribeToChanges(async (data_) => {
24-
data = data_;
25-
devToolsData = await connector.getDevToolsData();
26-
renderBody(data, devToolsData, connector);
18+
const data = await connector.getData();
19+
renderBody(data, connector);
20+
connector.subscribeToChanges(async (newData) => {
21+
renderBody(newData, connector);
2722
});
2823
}
2924

0 commit comments

Comments
 (0)