Repository navigation
fix(#1082): reveal folders through the desktop file manager - #1314
Open
jinchuntan wants to merge 2 commits into
Open
jinchuntan wants to merge 2 commits into
jinchuntan wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1082.
Use the same file-manager reveal API for desktop folders that files already use. The action reveals the folder in its parent directory instead of opening it through the default-application handler, which was reported as unreliable on Windows in #174. Mobile still opens the folder because the reveal API is unavailable there.
File and folder actions now share one path resolver. It reads the workspace once and uses the native path join for AppData, avoiding mixed Windows separators.
Added 5 tests covering Windows and POSIX paths, custom workspaces, network shares, mobile behavior and failures without a second launch. All 10 Node tests and lint pass. Menu and handler checks confirm the correct API and target path; the original folder menu fails that check. The production build passes with #1303 applied temporarily. Native calls were mocked, so I have not verified the original delay in Windows Explorer.
API reference: https://v2.tauri.app/reference/javascript/opener/
Assisted by Codex.