Repository navigation
fix(#1294): keep tab content paired with its file snapshot - #1312
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1294.
The editor wrapper paired content captured during render with a fresh
activeFilePathread inside its effects. If the active file changed between those steps, it could cache the previous note under the new path. Empty notes then kept showing that previous content.Use the path, content and loading flag from the same store snapshot. Apply completed empty-file updates too, and remove the separate event-based ownership flag.
Reproduced the failure before the fix and checked 8 React/Zustand scenarios covering empty and nonempty notes, cached tabs, delayed loading, clearing content, inactive editors and sync updates. All 5 existing Node tests and lint pass. The production build passes with #1303 applied temporarily. I have not run the native Windows app.
Assisted by Codex.