Repository navigation
feat(#1056): customize HTML exports with CSS and JavaScript - #1311
Open
jinchuntan wants to merge 2 commits into
Open
jinchuntan wants to merge 2 commits into
jinchuntan wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1056.
Add custom CSS and JavaScript fields under Editor settings. They are saved automatically and included only in exported HTML. Clearing both fields restores the default export. CSS and JavaScript are embedded as UTF-8 data URLs so Unicode and literal closing tags do not break the document.
Added 6 regression tests for encoding and export routing. All 11 Node tests and lint pass. A Chromium check confirms the CSS applies and JavaScript runs in the exported document. Component checks cover editing and queued saves. PDF and Markdown exports keep their original content, and exporting does not execute the custom script inside the app. Native PDF printing itself was stubbed in the test.
The production build passes with #1303 applied temporarily. Labels are included in all six languages.
Assisted by Codex.