Repository navigation
fix(#1046): open note links from AI replies inside NoteGen - #1309
Open
jinchuntan wants to merge 1 commit into
Open
jinchuntan wants to merge 1 commit into
jinchuntan wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1046.
Tell the agent to link local notes with workspace-relative Markdown paths rather than invented web URLs. Clicking those links in chat now opens an editor preview. Web links keep their usual behavior, and paths outside the workspace are not treated as note links.
Added tests for encoded filenames, Markdown extensions, web links, malformed URLs and parent-directory traversal. An interaction check also covers opening a preview and reporting failed opens. It fails on the original chat component. All 8 Node tests and lint pass. The production build passes with #1303 applied temporarily.
Assisted by Codex.