Repository navigation
feat(#1200): add independent inline code colors - #1308
Open
jinchuntan wants to merge 1 commit into
Open
jinchuntan wants to merge 1 commit into
jinchuntan wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1200.
Add text and background colors for inline code to the custom theme dialog. They save with the theme and survive export and import. Existing themes keep their current appearance until a color is chosen, and reset restores the defaults. The new colors do not change code blocks or the shared muted color. Labels are included in all six languages.
Checked both picker inputs, persistence, theme round trips and older presets. Chromium checks cover light and dark mode, reset and unchanged code block and muted styles. Lint and all 5 existing Node tests pass. The production build passes with #1303 applied temporarily.
Assisted by Codex.