Repository navigation
fix(#1081): keep records visible in narrow desktop windows - #1306
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1081.
The record sidebar used
hidden md:flex, so resizing a desktop window below 768px hid its contents. Keep it visible at every window width and let the sidebar tabs scroll when they run out of space, leaving room for the action buttons.Checked normal records and trash in Chromium at 560, 767, 768 and 1200px, including a 280px sidebar. The original code fails the narrow-window check. Lint and all 5 existing Node tests pass. The production build passes with the separate type fix from #1303 applied temporarily. I have not run the native macOS app.
Assisted by Codex.