Repository navigation
fix(#1300): migrate the saved search route on startup - #1302
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1300.
After an upgrade,
/core/searchcan remain saved as the last page even though that route no longer exists. Add it to the existing desktop migration so/core/mainis saved before navigation.Checked 18 startup scenarios by running the actual startup component with mocked storage, router and device detection. This covers the search migration, saving before navigation, reopening and existing desktop and mobile routes. All five existing Node tests and
next lintpass.Frontend compilation succeeds. The full type check and production build are blocked by existing TS7023 and TS7024 errors in
src/lib/sync/remote-file.ts. The unchangeddevrevision3798b1bproduces the same type-check errors. Windows desktop testing was not run.Assisted by Codex.