-
Notifications
You must be signed in to change notification settings - Fork 74
Fixes:[T348188] For PDL, download and stream the PDF if available #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes:[T348188] For PDL, download and stream the PDF if available #224
Conversation
coderwassananmol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will perform E2E testing post these review comments.
|
@coderwassananmol I have made the requested changes |
coderwassananmol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@okerekechinweotito In Trove and Google Books, we are using chunked upload. I request you to please follow the same method to ensure consistency across pdf files.
42e59fa to
5efd9a9
Compare
|
@coderwassananmol I have made the requested changes. |
5efd9a9 to
e77024c
Compare
coderwassananmol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tried uploading http://www.panjabdigilib.org/webuser/searches/displayPage.jsp?ID=2833&page=1&CategoryID=3&Searched=W3GX but it failed. Can you check why?
| job | ||
| ); | ||
| job.progress(100); | ||
| done(null, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the job fails? It will still return success.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderwassananmol I have pushed a fix for this
@coderwassananmol
|
It is expected. Can you submit a patch to resolve this? |
|
@coderwassananmol please what should the solution achieve...Should I make the description an emtpy string if it contains invalid characters so it can upload? |
@coderwassananmol |
|
@okerekechinweotito I debugged this further and found that the value of I think we need to fix the |
coderwassananmol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upload is working fine now.
Fixes: T348188
Proposed Changes
Files Created/Updated
Checklist