Skip to content

Conversation

@okerekechinweotito
Copy link
Contributor

@okerekechinweotito okerekechinweotito commented Oct 11, 2023

Fixes: T348600

Proposed Changes

  • The title/identifier should be displayed properly.
  • The placeholder text should say "Enter valid identifier"
  • The validation should accept either Alphabets, Numbers, or Alphanumeric characters
  • Restructure and Move Identifier validation into server.js

Files Created/Updated

  • components/Books.js - receive isInValidIdentifier response from server and implement frontend. Update the changeIdentifier placeholder
  • server.js - validate identifier and return isInValidIdentifier: true if validation fails

Current Look

Screenshot (40)

Checklist

  • Coding Conventions are followed.
  • Comments are used for Documenting the Code.
  • Correct File Names are mentioned.

Copy link
Owner

@coderwassananmol coderwassananmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the changes.

@okerekechinweotito
Copy link
Contributor Author

@coderwassananmol Bugs fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants