Fix: convert header to functional component #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parthiv-M
reviewed
Oct 9, 2023
Collaborator
|
You might want to wait until #182 is merged and then update the |
This was referenced Oct 9, 2023
Parthiv-M
approved these changes
Oct 11, 2023
Collaborator
Parthiv-M
left a comment
Parthiv-M
left a comment
There was a problem hiding this comment.
Works fine for me.
Since other changes in the header are stalled for now, we can get this merged
This was referenced Oct 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes T348415
Proposed Changes
Files Updated
header.js