Skip to content

Fixes:[T348192] Add max character limit while creating identifier in Internet Archive and remove some special characters #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coderwassananmol merged 2 commits into from
Oct 9, 2023
Merged

Fixes:[T348192] Add max character limit while creating identifier in Internet Archive and remove some special characters #187

coderwassananmol merged 2 commits into from
Oct 9, 2023

Conversation

@okerekechinweotito
Copy link
Contributor

@okerekechinweotito okerekechinweotito commented Oct 6, 2023 •
edited
Loading

Fixes: T348192

Proposed Changes

  • Validates if generated identifier is less than 50 characters and alphanumeric
  • Prompts user to enter a new identifier if validation fails

Files Created/Updated

  • components/ChangeIdentifier.js - Extract the component used in handling duplicate identifier into a new component called ChangeIdentifier to enable efficient reuse
  • components/Books.js - add a conditional that checks if the initial generated identifier is Alphanumeric and not more than 50 characters. If it fails the validation , reuse the new ChangeIdentifier component and prompt the user to enter a new identifier that meets the requirements.

Current Look

Screenshot (27)

Checklist

  • Coding Conventions are followed.
  • Comments are used for Documenting the Code.
  • Correct File Names are mentioned.

@okerekechinweotito okerekechinweotito mentioned this pull request Oct 7, 2023
Closed
3 tasks
@okerekechinweotito
Copy link
Contributor Author

okerekechinweotito commented Oct 7, 2023

@Parthiv-M Good-day
Please does this meet the criteria for T348192

@Parthiv-M
Copy link
Collaborator

Parthiv-M commented Oct 7, 2023

Works fine for me

coderwassananmol
coderwassananmol reviewed Oct 8, 2023
View reviewed changes
coderwassananmol
coderwassananmol approved these changes Oct 9, 2023
View reviewed changes
Copy link
Owner

@coderwassananmol coderwassananmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderwassananmol coderwassananmol merged commit c2f1f49 into coderwassananmol:develop Oct 9, 2023
@coderwassananmol coderwassananmol mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderwassananmol coderwassananmol coderwassananmol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@okerekechinweotito @Parthiv-M @coderwassananmol