Fixes: [T348188] For PDL, download and stream the PDF if available #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderwassananmol
requested changes
Oct 7, 2023
bull/pdl-queue/consumer.js
Outdated
| const IAuri = `http://s3.us.archive.org/${bucketTitle}/${bucketTitle}_images.zip`; | ||
| metadata = _.omit(metadata, "coverImage"); | ||
| let headers = setHeaders(metadata, byteLength, metadata.title); | ||
| let headers = setHeaders(metadata, byteLength, metadata.title, zip); |
Owner
There was a problem hiding this comment.
- "zip" should be in string.
- I think it's better you directly send the content type so that you don't need to do another check in the
setHeaders()function.
bull/pdl-queue/consumer.js
Outdated
| const requestURI = request(job.data.uri); | ||
| const bucketTitle = metadata.IAIdentifier; | ||
| const IAuri = `http://s3.us.archive.org/${bucketTitle}/${bucketTitle}.pdf`; | ||
| let headers = setHeaders(metadata, responseSize, metadata.title, pdf); |
Owner
There was a problem hiding this comment.
- "pdf" should be in string.
- I think it's better you directly send the content type so that you don't need to do another check in the
setHeaders()function.
Author
There was a problem hiding this comment.
I've made the requested changes
Owner
|
@shreyashidabral This PR is failing for me with the below error: I tried uploading this book from PDL. |
coderwassananmol
requested changes
Oct 9, 2023
Owner
coderwassananmol
left a comment
coderwassananmol
left a comment
There was a problem hiding this comment.
@shreyashidabral The new changes are failing with this error. Please fix and resubmit.
Owner
|
Closing this since #224 is being worked upon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: T348188
Changes Made
Files Updated