Skip to content

Fixes:[T346388] Allow multi-lingual books to be uploaded to Internet Archive #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
okerekechinweotito wants to merge 3 commits into from
Closed

Fixes:[T346388] Allow multi-lingual books to be uploaded to Internet Archive #185

okerekechinweotito wants to merge 3 commits into from

Conversation

@okerekechinweotito
Copy link
Contributor

@okerekechinweotito okerekechinweotito commented Oct 6, 2023 •
edited
Loading

Fixes: T346388

Proposed Changes

  • Prompt user to enter a new valid English Identifier if the previous identifier is non-english
  • Enable Books with non-English titles to be uploaded to internet Archive

Files Created/Updated

  • components/ChangeIdentifier.js - Extract the component used in handling duplicate identifier into a new component called ChangeIdentifier to enable efficient reuse
  • components/Books.js - add a conditional that checks if the initial generated identifier has English Characters. If it has non-English characters , reuse the new ChangeIdentifier component and prompt the user to enter a new valid English Identifier
  • bull/google-books-queue/consumer.js - I found that the meta data title and publisher values must also be English to be accepted by internet archive. So I implemented a check that validates the title and publisher values to be English Characters. If they are English their values are used, if they are not a string ('non english characters') is used

Current Look

Screenshot (22)

Checklist

  • Coding Conventions are followed.
  • Comments are used for Documenting the Code.
  • Correct File Names are mentioned.

@coderwassananmol
Copy link
Owner

coderwassananmol commented Oct 7, 2023

@okerekechinweotito We are changing the way identifiers are being generated and we are going to keep it only alphanumeric and a maximum of 50 characters in length. #184 addresses this issue. Once #184 is merged, you can pull the latest changes from develop and push the new changes in this branch.

@okerekechinweotito
Copy link
Contributor Author

okerekechinweotito commented Oct 7, 2023

@coderwassananmol
There is also a possible solution I created for that here 187 , that validates if the identifier has a maximum of 50 characters and is alphanumeric and prompts the user to enter a new identifier if validation fails

@coderwassananmol
Copy link
Owner

coderwassananmol commented Oct 9, 2023

#187 fixed it. Hence, closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@okerekechinweotito @coderwassananmol