Skip to content

Fixes [T348192]: Add max character limit while creating identifier in Internet Archive and remove some special characters #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shreyashidabral wants to merge 3 commits into from
Closed

Fixes [T348192]: Add max character limit while creating identifier in Internet Archive and remove some special characters #184

shreyashidabral wants to merge 3 commits into from

Conversation

@shreyashidabral
Copy link

@shreyashidabral shreyashidabral commented Oct 5, 2023 •
edited
Loading

Fixes: T348192

Files Updated

  • components/InputIdentifier.js - Created a new reusable component from existing code for inputting new identifier.

  • components/Books.js - to add a valid Identifier check i.e.

  1. Does not exceed 50 characters in length.
  2. Contains only alphanumeric characters.
    And if identifier is invalid, show appropriate information and ask the user to provide a new valid identifier with the help of InputIdentifier component.
  • utils/helper.js - to feature functions for validating identifiers

@shreyashidabral shreyashidabral changed the title Fixes [T348192]: Add max character limit while creating identifier in Internet Archive Add max character limit while creating identifier in Internet Archive and remove some special characters Fixes [T348192]: Add max character limit while creating identifier in Internet Archive and remove some special characters Oct 5, 2023
@coderwassananmol
Copy link
Owner

coderwassananmol commented Oct 5, 2023

@Parthiv-M Can you do a quick review here?

@Parthiv-M
Copy link
Collaborator

Parthiv-M commented Oct 5, 2023

Couple of things here

  • Upon clicking the Submit button, it seems to be throwing an error

      error - unhandledRejection: ReferenceError: isAlphanumeric is not defined
  at isTitleValid (BUB2/utils/helper.js:29:25)
  at wikimedia/BUB2/server.js:392:33
  at processTicksAndRejections (internal/process/task_queues.js:95:5)

  • I see you have created a new function called generateIdentifier. The task mentions that if the length of the title is more than 50 characters or if it is not alphanumeric, then the user needs to be able to provide a custom identifier.

    The code that was built to handle duplicate identifiers can be reused. You might have to draft it into a separate component and then make the required changes.

@coderwassananmol coderwassananmol mentioned this pull request Oct 7, 2023
Closed
3 tasks
@shreyashidabral
Copy link
Author

shreyashidabral commented Oct 8, 2023

@Parthiv-M I've made the requested changes.

@coderwassananmol
Copy link
Owner

coderwassananmol commented Oct 9, 2023

#187 fixed it. Hence closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shreyashidabral @coderwassananmol @Parthiv-M