Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coderefinery/sphinx-lesson
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: coderefinery/sphinx-lesson
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: rkdarst/transform-colons
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Dec 9, 2020

  1. sphinx_lesson/md_transforms: Add ::: to ``` transsformation 

    - This is similar to this special syntax in myst_parser:
  https://myst-parser.readthedocs.io/en/latest/using/syntax-optional.html#admonition-directives
- But that only works for special-cased directives, and is handled
  slightly differently.  See
  executablebooks/MyST-Parser#213 for a
  discussion of supporting other directives.
- Anyway, unless some upstream changes is made, the point is that
  support won't work for sphinx-lesson directives.
- Review: first wait to see if MyST-parser will add support for
  arbitrary directives, and then review.  Review: general check + read
  docs in detail.
    @rkdarst
    rkdarst committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    2e4904d View commit details
    Browse the repository at this point in the history
Loading