Enable note foreach and remove async

tbranyen · johnhaley81 · commit fab9237a544a · 2015-04-17T21:15:08.000-07:00
And added testing goodness!
diff --git a/generate/input/callbacks.json b/generate/input/callbacks.json
@@ -273,7 +273,11 @@
   "git_note_foreach_cb": {
     "args": [
       {
-        "name": "id",
+        "name": "blob_id",
+        "cType": "const git_oid *"
+      },
+      {
+        "name": "annotated_object_id",
         "cType": "const git_oid *"
       },
       {
@@ -283,7 +287,7 @@
     ],
     "return": {
       "type": "int",
-      "noResults": 1,
+      "noResults": 0,
       "success": 0,
       "error": -1
     }
diff --git a/generate/input/descriptor.json b/generate/input/descriptor.json
@@ -960,8 +960,17 @@
             }
           }
         },
+        "git_note_remove": {
+          "isAsync": true,
+          "return": {
+            "isErrorCode": true
+          }
+        },
         "git_note_foreach": {
-          "ignore": true
+          "isAsync": true,
+          "return": {
+            "isErrorCode": true
+          }
         }
       }
     },
diff --git a/lib/note.js b/lib/note.js
@@ -0,0 +1,9 @@
+var NodeGit = require("../");
+
+var Note = NodeGit.Note;
+
+// Override Note.foreach to eliminate the need to pass null payload
+var foreach = Note.foreach;
+Note.foreach = function(repo, notesRef, callback) {
+  return foreach(repo, notesRef, callback, null);
+};
diff --git a/test/tests/note.js b/test/tests/note.js
@@ -6,7 +6,7 @@ describe("Note", function() {
   var NodeGit = require("../../");
   var Note = NodeGit.Note;
   var Signature = NodeGit.Signature;
-  var reposPath = local("../repos/merge");
+  var reposPath = local("../../");
 
   beforeEach(function() {
     var test = this;
@@ -37,16 +37,33 @@ describe("Note", function() {
     });
   });
 
+  it("can iterate all notes", function() {
+    var test = this;
+    var noteRef = "refs/notes/commits";
+    var ref = null;
+
+    return Note.foreach(this.repository, noteRef, function(blobId, objectId) {
+      ref = objectId;
+    }).then(function() {
+      return NodeGit.Note.read(test.repository, noteRef, ref)
+        .then(function(note) {
+          assert.equal(note.message(), "Testing!");
+        });
+    });
+  });
+
   it("can be removed", function(done) {
+    var test = this;
     var sha = this.commit.id();
     var noteRef = "refs/notes/commits";
     var sig = Signature.create("John", "john@doe.com", Date.now(), 0);
 
-    Note.remove(this.repository, noteRef, sig, sig, sha);
-
-    return Note.read(this.repository, noteRef, sha).catch(function(ex) {
-      assert.equal(ex.message, "Note could not be found");
-      done();
-    });
+    return Note.remove(this.repository, noteRef, sig, sig, sha)
+      .then(function() {
+        return Note.read(test.repository, noteRef, sha).catch(function(ex) {
+          assert.equal(ex.message, "Note could not be found");
+          done();
+        });
+      });
   });
 });

Original file line number	Diff line number	Diff line change
`@@ -960,8 +960,17 @@`
`960`	`960`	`}`
`961`	`961`	`}`
`962`	`962`	`},`
	`963`	`+ "git_note_remove": {`
	`964`	`+ "isAsync": true,`
	`965`	`+ "return": {`
	`966`	`+ "isErrorCode": true`
	`967`	`+ }`
	`968`	`+ },`
`963`	`969`	`"git_note_foreach": {`
`964`		`- "ignore": true`
	`970`	`+ "isAsync": true,`
	`971`	`+ "return": {`
	`972`	`+ "isErrorCode": true`
	`973`	`+ }`
`965`	`974`	`}`
`966`	`975`	`}`
`967`	`976`	`},`