Apparently you should only null check pointers

John Haley · John Haley · commit e44e74746320 · 2014-10-24T10:47:22.000-07:00
diff --git a/generate/partials/sync_function.cc b/generate/partials/sync_function.cc
@@ -55,9 +55,12 @@ from_{{ arg.name }}
 {%if not .|returnsCount %}
   NanReturnUndefined();
 {%else%}
+  {%if return.cType | isPointer %}
+  // null checks on pointers
   if (!result) {
-    NodeGitPsueodoNanReturnEscapingValue(NanNull());
+    NodeGitPsueodoNanReturnEscapingValue(NanUndefined());
   }
+  {%endif%}
 
   Handle<Value> to;
   {%if .|returnsCount > 1 %}
diff --git a/test/tests/attr.js b/test/tests/attr.js
@@ -1,7 +1,7 @@
 var assert = require("assert");
 var path = require("path");
 
-describe("Blob", function() {
+describe("Attr", function() {
   var reposPath = path.resolve("test/repos/workdir/.git");
 
   var Repository = require("../../lib/repository");
@@ -29,11 +29,11 @@ describe("Blob", function() {
   it.skip("can lookup the value of a git attribute", function() {
     var flags = Attr.Check.NO_SYSTEM;
     var getAttr = Attr.get(this.repository, flags, ".gitattributes", "test");
-    
+
     return getAttr.then(function(val) {
       console.log(val);
     }).catch(function(ex) {
-      console.log(ex); 
+      console.log(ex);
     });
   });
 });
diff --git a/test/tests/remote.js b/test/tests/remote.js
@@ -61,7 +61,7 @@ describe("Remote", function() {
     });
   });
 
-  it.only("can push a remote", function() {
+  it("can push a remote", function() {
     return Remote.load(this.repository, "origin").then(function(remote) {
       assert(remote.pushurl(), "https://github.com/nodegit/nodegit");
     });
