Fix issue nodegit#591 - error when calling path() on a TreeEntry that was obtained from Tree.entries().

Tom Ruggles · Tom Ruggles · commit 697ba01094db · 2015-05-28T21:48:08.000-04:00
diff --git a/lib/tree_entry.js b/lib/tree_entry.js
@@ -79,10 +79,6 @@ TreeEntry.prototype.getBlob = function(callback) {
  * @return {String}
  */
 TreeEntry.prototype.path = function(callback) {
-  console.log({
-    path: this.parent.path(),
-    dirtoparent: this.dirtoparent,
-    filename: this.filename()});
   var dirtoparent = this.dirtoparent || "";
   return path.join(this.parent.path(), dirtoparent, this.filename());
 };
diff --git a/package.json b/package.json
@@ -74,7 +74,8 @@
     "nw-gyp": "^0.12.4",
     "pangyp": "^2.1.0",
     "request": "^2.55.0",
-    "tar": "^2.1.0"
+    "tar": "^2.1.0",
+    "bluebird": "^2.9.26"
   },
   "binary": {
     "module_name": "nodegit",
diff --git a/test/tests/tree_entry.js b/test/tests/tree_entry.js
@@ -1,4 +1,5 @@
 var assert = require("assert");
+var promise = require("bluebird");
 var path = require("path");
 var local = path.join.bind(path, __dirname);
 
@@ -52,6 +53,33 @@ describe("TreeEntry", function() {
       });
   });
 
+  it("provides the full path when the entry came from a tree", function(done) {
+    var testTree = function(tree, _dir) {
+      var dir = _dir || "",
+        testPromises = [];
+      tree.entries().forEach(function(entry) {
+        var currentPath = path.join(dir, entry.filename());
+        if (entry.isTree()) {
+          testPromises.push(
+            entry.getTree().then(function (subtree) {
+              return testTree(subtree, currentPath);
+            })
+          );
+        } else {
+          assert.equal(entry.path(), currentPath);
+        }
+      });
+
+      return promise.all(testPromises);
+    };
+
+    return this.commit.getTree()
+      .then(testTree)
+      .done(function() {
+        done();
+      });
+  });
+
   it("provides the blob representation of the entry", function() {
     return this.commit.getEntry("test/raw-commit.js")
       .then(function(entry) {
