healthcare API: fix flaky test (GoogleCloudPlatform#3333)

noerog · web-flow · commit 2b836bb118a0 · 2020-07-10T10:27:11.000-07:00
* healthcare API: fix flaky test

* add comments
diff --git a/healthcare/v1/src/main/java/snippets/healthcare/hl7v2/messages/HL7v2MessageList.java b/healthcare/v1/src/main/java/snippets/healthcare/hl7v2/messages/HL7v2MessageList.java
@@ -29,7 +29,6 @@
 import com.google.auth.oauth2.GoogleCredentials;
 import java.io.IOException;
 import java.util.Collections;
-import java.util.List;
 
 public class HL7v2MessageList {
   private static final String HL7v2_NAME = "projects/%s/locations/%s/datasets/%s/hl7V2Stores/%s";
@@ -47,8 +46,6 @@ public static void hl7v2MessageList(String hl7v2StoreName) throws IOException {
     // Results are paginated, so multiple queries may be required.
     String pageToken = null;
 
-    List<Message> hl7v2Messages;
-
     do {
       // Create request and execute.
       ListMessagesResponse messageResponse =
@@ -63,17 +60,17 @@ public static void hl7v2MessageList(String hl7v2StoreName) throws IOException {
               .setPageToken(pageToken)
               .execute();
 
-      // Collect results.
-      hl7v2Messages = messageResponse.getHl7V2Messages();
-
+      if (messageResponse.getHl7V2Messages() != null) {
+        // Print results.
+        System.out.printf(
+            "Retrieved %s HL7v2 messages: \n", messageResponse.getHl7V2Messages().size());
+        for (Message message : messageResponse.getHl7V2Messages()) {
+          System.out.println(message);
+        }
+      }
       // Update the page token for the next request.
       pageToken = messageResponse.getNextPageToken();
     } while (pageToken != null);
-    // Print results.
-    System.out.printf("Retrieved %s HL7v2 messages: \n", hl7v2Messages.size());
-    for (Message message : hl7v2Messages) {
-      System.out.printf("%s\n", message.getName());
-    }
   }
 
   private static CloudHealthcare createClient() throws IOException {
diff --git a/healthcare/v1/src/test/java/snippets/healthcare/Hl7v2MessageTests.java b/healthcare/v1/src/test/java/snippets/healthcare/Hl7v2MessageTests.java
@@ -136,6 +136,11 @@ public void test_GetHL7v2Message() throws Exception {
 
   @Test
   public void test_Hl7v2MessageList() throws Exception {
+    // There can be a delay between when a message is created
+    // or ingested and when it's viewable when listing messages
+    // in a store, so sleep for 10 seconds while waiting for
+    // the message to fully propagate.
+    Thread.sleep(10000);
     HL7v2MessageList.hl7v2MessageList(hl7v2StoreName);
 
     String output = bout.toString();
