ENH make pipeline.named_steps a property, fix pipeline.named_steps doctest

amueller · amueller · commit 6bd084489c30 · 2015-05-07T14:37:04.000-04:00
diff --git a/sklearn/pipeline.py b/sklearn/pipeline.py
@@ -74,19 +74,22 @@ class Pipeline(BaseEstimator):
     >>> anova_svm.score(X, y)                        # doctest: +ELLIPSIS
     0.77...
     >>> # getting the selected features chosen by anova_filter
-    >>> support = anova_svm.named_steps.get_support()
+    >>> anova_svm.named_steps['anova'].get_support()
+    ... # doctest: +NORMALIZE_WHITESPACE
+    array([ True,  True,  True, False, False,  True, False,  True,  True, True,
+           False, False,  True, False,  True, False, False, False, False,
+           True], dtype=bool)
     """
 
     # BaseEstimator interface
 
     def __init__(self, steps):
-        self.named_steps = dict(steps)
         names, estimators = zip(*steps)
-        if len(self.named_steps) != len(steps):
-            raise ValueError("Names provided are not unique: %s" % (names,))
+        if len(dict(steps)) != len(steps):
+            raise ValueError("Provided step names are not unique: %s" % (names,))
 
         # shallow copy of steps
-        self.steps = tosequence(zip(names, estimators))
+        self.steps = tosequence(steps)
         transforms = estimators[:-1]
         estimator = estimators[-1]
 
@@ -110,14 +113,18 @@ def get_params(self, deep=True):
         if not deep:
             return super(Pipeline, self).get_params(deep=False)
         else:
-            out = self.named_steps.copy()
+            out = self.named_steps
             for name, step in six.iteritems(self.named_steps):
                 for key, value in six.iteritems(step.get_params(deep=True)):
                     out['%s__%s' % (name, key)] = value
 
             out.update(super(Pipeline, self).get_params(deep=False))
             return out
 
+    @property
+    def named_steps(self):
+        return dict(self.steps)
+
     @property
     def _final_estimator(self):
         return self.steps[-1][1]
