Improve tests, handle trailing space after value.

brian-brazil · brian-brazil · commit 8f5ea53cc2bb · 2018-09-07T17:17:03.000+01:00
Signed-off-by: Brian Brazil &lt;brian.brazil@robustperception.io&gt;
diff --git a/prometheus_client/openmetrics/parser.py b/prometheus_client/openmetrics/parser.py
@@ -127,6 +127,10 @@ def _parse_sample(text):
             else:
                 timestamp.append(char)
 
+    # Trailing space after value.
+    if state == 'timestamp' and not timestamp:
+        raise ValueError("Invalid line: " + text)
+
     if not value:
         raise ValueError("Invalid line: " + text)
     value = ''.join(value)
diff --git a/tests/openmetrics/__init__.py b/tests/openmetrics/__init__.py
diff --git a/tests/openmetrics/test_parser.py b/tests/openmetrics/test_parser.py
@@ -373,8 +373,11 @@ def test_invalid_input(self):
                 ('0a 1\n# EOF\n'),
                 ('a.b 1\n# EOF\n'),
                 ('a-b 1\n# EOF\n'),
+                # Bad value.
+                ('a a\n# EOF\n'),
+                ('a  1\n# EOF\n'),
+                ('a 1 \n# EOF\n'),
                 # Bad timestamp.
-                ('a 1 1 \n# EOF\n'),
                 ('a 1 z\n# EOF\n'),
                 ('a 1 1z\n# EOF\n'),
                 ('a 1 1.1.1\n# EOF\n'),
