Repository navigation
Conversation
EhabY
force-pushed
the
fix/vsc-8-ssh-g-remote-command
branch
2 times, most recently
from
November 17, 2026 14:23
56a81a5 to
bbb0962
Compare
…type with SendEnv Refs VSC-8
EhabY
force-pushed
the
fix/vsc-8-ssh-g-remote-command
branch
from
November 17, 2026 14:37
bbb0962 to
07b4e92
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After writing the generated SSH config, the extension resolved the Coder host's options with a manual parser that ignores
Include,Matchand negatedHostlines, so aRemoteCommandfrom any of them went undetected. The host is now resolved withssh -G, using the ssh executable the active Remote-SSH extension is configured with, and falls back to the parser if ssh fails.Also in this PR:
PermitLocalCommand no: the generated block sets it, so aLocalCommandelsewhere in the user's config never runs for workspaces.SendEnvinstead ofSetEnv: the session type is set in the environment ssh inherits and forwarded withSendEnv. This works on every OpenSSH version, so thessh -Vcheck is gone.remote.devinSSH.configFileto ssh, so Coder hosts go into that file there.Refs VSC-8. The post-write check the issue describes was already removed in #1061. Follow-up: VSC-52 (deny deployment-set
SendEnv).Decision log
ssh -G.remote.SSH.path(Microsoft, Cursor, open-remote-ssh in native mode),remote.devinSSH.pathandremote.antigravitySSH.path.SendEnv: I checked against a real sshd that it delivers the same value asSetEnv. Every extension spawns ssh withprocess.env. open-remote-ssh's defaultssh2backend ignoredSetEnvand exportsSendEnvvalues in its setup script instead of sending them, so the agent still sees a plain SSH session there, as onmain: SendEnv is exported in the setup script instead of sent as SSH env requests (ssh2 backend) jeanp413/open-remote-ssh#415.-F: no release from 2.0.44 to 3.11.238 passes it. 3.12.32+ does, read fromwindsurfVersioninproduct.json. Antigravity never passes it.Generated by Coder Agents on behalf of @EhabY.