Skip to content

fix: show deployment-provided text in notifications as plain text - #1187

Merged
EhabY merged 3 commits into
mainfrom
fix/notification-plain-text
Nov 12, 2026
Merged

EhabY merged 3 commits into
mainfrom
fix/notification-plain-text

Conversation

@EhabY

@EhabY EhabY commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

VS Code turns [text](target) in a notification message into a clickable link. Some notifications include text from the deployment, templates, the workspace, or the Coder CLI, so that text could show up as a link.

escapeNotificationLinks writes ]( as ] (, so the text stays readable but is no longer a link:

  • Startup script names, app status messages, and Coder CLI errors (speedtest, netcheck, support bundle, storing credentials): every link shows as text.
  • Template version messages and inbox titles: http(s):// links stay clickable, so admins can still link to a changelog or docs. Other links (command:, file:) show as text.

Notifications with only extension-written text are unchanged.

Follow-up: route notifications through one wrapper and add a lint rule against calling window.show*Message directly, so new notifications get the same treatment.


Generated by Coder Agents on behalf of @EhabY.

@EhabY
EhabY merged commit 6acc293 into main Nov 12, 2026
13 checks passed
@EhabY
EhabY deleted the fix/notification-plain-text branch November 12, 2026 13:25
@EhabY EhabY mentioned this pull request Nov 13, 2026
@linear-code

linear-code Bot commented Nov 13, 2026

Copy link
Copy Markdown

SEC-1189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants