Skip to content

fix!: set the minimum supported Coder version to 2.29.0 - #1186

Merged
EhabY merged 5 commits into
mainfrom
fix/issue-1180-minimum-coder-version
Nov 12, 2026
Merged

EhabY merged 5 commits into
mainfrom
fix/issue-1180-minimum-coder-version

Conversation

@EhabY

@EhabY EhabY commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Set the minimum supported Coder server and CLI versions to 2.29.0, independently. Remove older compatibility branches while retaining newer capability checks and file-backed credentials. Check the server floor at login and CLI binary resolution, and validate known CLI versions after parsing. Unknown CLI versions use baseline capabilities, never the server version.

Closes #1180.

Agreed implementation plan and validation

Plan and decisions

  1. Use a fixed 2.29.0 floor for both server and CLI, without a rolling support window or JetBrains policy changes.
  2. Remove baseline capability flags and their fallback paths: CLI login, proxy logging, wildcard SSH, build reason, CLI update, keyring support, SSH commands, and support bundles. Retain capabilities introduced after 2.29 and the Tasks API upper bound.
  3. Add lightweight server checks before login authentication/persistence and during binary resolution, sharing the floor and error message. Preserve development builds and existing login error handling, including redirect recovery. Do not add checks to every CLI execution path.
  4. Resolve CLI and server capabilities independently. Validate known CLI versions after parsing; unknown CLI versions use baseline capabilities. Keep raw cache/download comparisons unchanged so old binaries can still be upgraded. Preserve file storage, best-effort credential handling, and the token-reading fallback needed on 2.29 through 2.31.
  5. Keep the README compatibility matrix and binary-location setting description concise, add the breaking-change changelog entry, and remove obsolete notices. Inline the single-caller SSH command builder and remove redundant keyring and empty-log-path conditions.
  6. Update regression coverage and run tests, typecheck, lint, formatting, build, and integration checks.

Verified results

  • Unit/webview suite: 3,142 passed, 6 platform/environment skips.
  • Typecheck, lint, formatting, build, and diff checks passed.
  • Integration suite: 5 passed on each of VS Code 1.105.0 and 1.145.2.
  • Regression controls caught removal of the server and CLI gates, swallowed CLI compatibility errors, server-derived CLI capabilities, loss of the development-build exception, bypassed redirect recovery, and misleading credential-error advice. All control mutations were restored.
  • Independent review verified login error recovery, separate CLI validation, and credential-error advice; no remaining blockers.

No live Coder 2.29 deployment was used for end-to-end validation. Version checks run at resolution points, not before every command. Unknown CLI versions retain baseline capabilities; best-effort credential reads and cleanup retain their existing failure handling.

Generated by Coder Agents on behalf of @EhabY.

@EhabY
EhabY marked this pull request as ready for review November 9, 2026 16:49
@EhabY
EhabY requested a review from jeremyruppel November 9, 2026 18:06
@EhabY EhabY self-assigned this Nov 9, 2026
Comment thread src/featureSet.ts Resolved

@jeremyruppel jeremyruppel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice! two little comments, but this looks great to me! 👍

@EhabY
EhabY force-pushed the fix/issue-1180-minimum-coder-version branch from 75632c4 to 1d68070 Compare November 12, 2026 14:56
@EhabY
EhabY merged commit 6532d25 into main Nov 12, 2026
12 checks passed
@EhabY
EhabY deleted the fix/issue-1180-minimum-coder-version branch November 12, 2026 15:00
@linear-code

linear-code Bot commented Nov 13, 2026

Copy link
Copy Markdown

SEC-435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define and document the minimum supported Coder server/CLI version

2 participants