Repository navigation
fix(oauth): keep OAuth endpoints and requests on the deployment origin - #1177
Merged
Merged
Conversation
code-asher
reviewed
Nov 6, 2026
EhabY
force-pushed
the
fix/oauth-origin
branch
from
November 9, 2026 09:54
ea3a70a to
3b8c6dd
Compare
EhabY
force-pushed
the
fix/oauth-origin
branch
from
November 9, 2026 10:21
3b8c6dd to
89ff1f4
Compare
code-asher
approved these changes
Nov 11, 2026
- Reject OAuth metadata endpoints off the deployment origin or under a workspace app path, without echoing them. - Send OAuth POSTs with maxRedirects: 0. - Show OAuth failures in a modal's plain detail, not a notification that renders command links. - Clean up superseded or disposed flows, and open the browser without awaiting it so early rejections reach the caller. - Ignore a coder.alternativeWebUrl that is not http(s).
- Rely on the client's cross-origin redirect guard instead of maxRedirects: 0 on OAuth POSTs. - Use coder.alternativeWebUrl as configured again; it is application-scoped, so only the user can set it. - Split the endpoint error into origin and workspace app path cases and name the endpoint, which only reaches logs and the plain-text dialog.
EhabY
force-pushed
the
fix/oauth-origin
branch
from
November 11, 2026 11:45
89ff1f4 to
d4ac606
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps OAuth endpoints, requests, and error text on the deployment's own origin.
/@user/...) are rejected, with an error naming the endpoint.[text](command:...)links in server text.stateis no longer logged.OAuth POSTs rely on the client's existing cross-origin redirect guard.
Not in this PR: OAuth requests still carry the session token (revocation relies on it), and the dialog can start a second flow after another window's login wins.
Stacked on #1176; review that first.