Skip to content

fix(websocket): time out stalled handshakes - #1172

Merged
EhabY merged 1 commit into
mainfrom
fix/websocket-handshake-timeout
Oct 30, 2026
Merged

EhabY merged 1 commit into
mainfrom
fix/websocket-handshake-timeout

Conversation

@EhabY

@EhabY EhabY commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

A WebSocket whose server accepted the connection but never answered the upgrade hung with no error or retry. WebSockets now use the same 60s timeout as API requests, so a stalled handshake fails and the normal reconnect takes over.


Generated by Coder Agents on behalf of @EhabY.

@EhabY
EhabY force-pushed the fix/websocket-handshake-timeout branch 2 times, most recently from e8770a1 to c4c90c7 Compare October 30, 2026 11:05
A WebSocket whose server accepted the connection but never answered the
upgrade hung with no error or retry. Use the same 60s timeout as API
requests.
@EhabY
EhabY force-pushed the fix/websocket-handshake-timeout branch from c4c90c7 to 40ec581 Compare October 30, 2026 11:22

@code-asher code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but just calling out this change is still in the other PR! (You might already be planning on removing it, but calling it out just in case.)

@code-asher

code-asher commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Oh wait I see, everything was broken out so I assume the other PR will just be closed. Ignore me!

@EhabY
EhabY merged commit d79dd8b into main Oct 30, 2026
12 checks passed
@EhabY
EhabY deleted the fix/websocket-handshake-timeout branch October 30, 2026 21:29
@EhabY EhabY mentioned this pull request Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants