Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the server keep-alive times out, only the session channel was closed. The connection and its context stayed open, so anything waiting on
ctx.Done()(such as the Coder agent's connection reporting) never learned the client was gone. OpenSSH drops the whole connection in this case (ClientAliveCountMax).This closes the connection instead, which ends every session on it and cancels the context. The previously skipped subtest now covers it by dropping client data through
ConnCallback; it fails without the fix.Part of fixing stale "Ongoing" SSH connection logs; see coder/coder#32353. A fork bump in coder/coder follows.
Verification
With this fork replaced into coder/coder plus #32353, a client that goes silent (3s agent keep-alive) gets its disconnect reported within 8s; without this change it is never reported.
Written with Coder Agents and reviewed by @EhabY.