Repository navigation
fix: only allow promoting successful template versions - #9998
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
aslilac
force-pushed
the
only-promote-successful-builds
branch
from
October 2, 2023 23:23
70e9cd6 to
6dc8fc3
Compare
BrunoQuaresma
left a comment
Contributor
There was a problem hiding this comment.
FE code looks good but since most of the changes are related to Go, I would also request a review from someone with more expertise on that
spikecurtis
reviewed
Oct 4, 2023
spikecurtis
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9904
Hide "canceled" versions from the UI entirely