Skip to content

fix(cli): remove exp scaletest from slim binary - #9934

Merged
johnstcn merged 8 commits into
mainfrom
cj/exp-scaletest-not-slim
Oct 3, 2023
Merged

johnstcn merged 8 commits into
mainfrom
cj/exp-scaletest-not-slim

Conversation

@johnstcn

@johnstcn johnstcn commented Sep 29, 2023 •

Copy link
Copy Markdown
Member

#9927 (comment)

These new imports add 5MB to the slim binary

Comment thread cli/exp_scaletest_slim.go Resolved
@johnstcn
johnstcn force-pushed the cj/exp-scaletest-not-slim branch from 4304425 to ead423e Compare October 3, 2023 10:50
@johnstcn
johnstcn marked this pull request as ready for review October 3, 2023 11:51
@johnstcn
johnstcn requested a review from mafredri October 3, 2023 11:51
@johnstcn
johnstcn requested a review from mtojek October 3, 2023 12:43

@mtojek mtojek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnstcn
johnstcn merged commit 9aac152 into main Oct 3, 2023
@johnstcn
johnstcn deleted the cj/exp-scaletest-not-slim branch October 3, 2023 14:13
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants