Skip to content

refactor(cli)!: remove reset-password from slim binary - #9520

Merged
mafredri merged 1 commit into
mainfrom
mafredri/refactor-remove-resetpw-from-slim
Sep 4, 2023
Merged

mafredri merged 1 commit into
mainfrom
mafredri/refactor-remove-resetpw-from-slim

Conversation

@mafredri

@mafredri mafredri commented Sep 4, 2023

Copy link
Copy Markdown
Member

This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380

❯ ls -lh build
-rwxr-xr-x 1 coder coder 44M Sep  4 16:12 coder-slim_2.1.4-devel+ad23d33f2_linux_amd64*
-rwxr-xr-x 1 coder coder 42M Sep  4 16:12 coder-slim_2.1.4-devel+ef51f8dcf_linux_amd64*
-rwxr-xr-x 2 coder coder 39M Sep  4 16:12 coder-slim_2.1.4-devel+17960ddc7_linux_amd64*

This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380
@mafredri mafredri self-assigned this Sep 4, 2023
@github-actions github-actions Bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Sep 4, 2023
@mafredri
mafredri merged commit d211594 into main Sep 4, 2023
@mafredri
mafredri deleted the mafredri/refactor-remove-resetpw-from-slim branch September 4, 2023 16:38
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release/breaking This label is applied to PRs to detect breaking changes as part of the release process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants