Skip to content

refactor(coderd/database): generate dbresetpw with queries for reset-password command - #9519

Closed
mafredri wants to merge 1 commit into
mainfrom
mafredri/refactor-cli-resetpassword
Closed

mafredri wants to merge 1 commit into
mainfrom
mafredri/refactor-cli-resetpassword

Conversation

@mafredri

@mafredri mafredri commented Sep 4, 2023 •

Copy link
Copy Markdown
Member

This change removes 1 MB from the slim binary, and combined with the
following PRs: #9481, #9506, #9508, #9517, a total of 4 MB.

Ref: #9380

❯ ls -lh build
total 125M
-rwxr-xr-x 1 coder coder 44M Sep  4 15:24 coder-slim_2.1.4-devel+ad23d33f2_linux_amd64*
-rwxr-xr-x 1 coder coder 43M Sep  4 15:27 coder-slim_2.1.4-devel+a1ad9cd3e_linux_amd64*
-rwxr-xr-x 1 coder coder 40M Sep  4 15:25 coder-slim_2.1.4-devel+bbb1fd609_linux_amd64*

See alternative approach: #9520

…password command

This change removes 1 MB from the slim binary, and combined with the
following PRs: #9481, #9506, #9508, #9517, a total of 4 MB.

Ref: #9380
@mafredri mafredri self-assigned this Sep 4, 2023
mafredri added a commit that referenced this pull request Sep 4, 2023
This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380
@johnstcn

johnstcn commented Sep 4, 2023

Copy link
Copy Markdown
Member

As the reset-password command requires direct database access to work, I would not expect the Coder database to be accessible from places where the slim CLI is being run, so I'm not sure this is the best approach here.

Removing the reset-password command from the slim CLI would technically be a breaking change, but it is unlikely to make a difference outside of running Coder locally.

@mafredri

mafredri commented Sep 4, 2023

Copy link
Copy Markdown
Member Author

Closing as removing the subcommand is preferred 👍🏻

@mafredri mafredri closed this Sep 4, 2023
@mafredri
mafredri deleted the mafredri/refactor-cli-resetpassword branch September 4, 2023 16:20
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants