Skip to content

refactor(coderd/telemetry): move CLI telemetry to cli/telemetry - #9517

Merged
mafredri merged 1 commit into
mainfrom
mafredri/refactor-cli-telemetry
Sep 4, 2023
Merged

mafredri merged 1 commit into
mainfrom
mafredri/refactor-cli-telemetry

Conversation

@mafredri

@mafredri mafredri commented Sep 4, 2023

Copy link
Copy Markdown
Member

This change removes an indirect import of coderd/database from the
slim binary.

No size change (yet).

Ref: #9380

@mafredri mafredri self-assigned this Sep 4, 2023
@mafredri mafredri changed the title refactor(coderd/telemetry): Move CLI telemetry to cli/telemetry refactor(coderd/telemetry): move CLI telemetry to cli/telemetry Sep 4, 2023
This change removes an indirect import of `coderd/database` from the
slim binary.

No size change (yet).

Ref: #9380
@mafredri
mafredri force-pushed the mafredri/refactor-cli-telemetry branch from 322f257 to 2019a5e Compare September 4, 2023 15:22
mafredri added a commit that referenced this pull request Sep 4, 2023
…password command

This change removes 1 MB from the slim binary, and combined with the
following PRs: #9481, #9506, #9508, #9517, a total of 4 MB.

Ref: #9380
mafredri added a commit that referenced this pull request Sep 4, 2023
This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380
mafredri added a commit that referenced this pull request Sep 4, 2023
This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380
@mafredri
mafredri merged commit adba421 into main Sep 4, 2023
@mafredri
mafredri deleted the mafredri/refactor-cli-telemetry branch September 4, 2023 18:42
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants