Skip to content

refactor(cli): use codersdk for provisioner types - #9508

Merged
mafredri merged 2 commits into
mainfrom
mafredri/refactor-provisioner-type
Sep 4, 2023
Merged

mafredri merged 2 commits into
mainfrom
mafredri/refactor-provisioner-type

Conversation

@mafredri

@mafredri mafredri commented Sep 4, 2023

Copy link
Copy Markdown
Member

This change removes one use of coderd/database from the slim binary
and more correctly uses codersdk instead of database or provisionerd
packages.

No size change (yet).

Ref: #9380

This change removes one use of `coderd/database` from the slim binary
and more correctly uses codersdk instead of database or provisionerd
packages.

No size change (yet).

Ref: #9380
@mafredri mafredri self-assigned this Sep 4, 2023
mafredri added a commit that referenced this pull request Sep 4, 2023
…password command

This change removes 1 MB from the slim binary, and combined with the
following PRs: #9481, #9506, #9508, #9517, a total of 4 MB.

Ref: #9380
mafredri added a commit that referenced this pull request Sep 4, 2023
This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380
mafredri added a commit that referenced this pull request Sep 4, 2023
This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380
@mafredri
mafredri merged commit b240799 into main Sep 4, 2023
@mafredri
mafredri deleted the mafredri/refactor-provisioner-type branch September 4, 2023 18:42
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants