Repository navigation
Conversation
kylecarbs
approved these changes
Sep 1, 2023
mafredri
force-pushed
the
mafredri/refactor-scaletest
branch
2 times, most recently
from
September 1, 2023 13:42
a02bebd to
7e27734
Compare
johnstcn
requested changes
Sep 1, 2023
johnstcn
left a comment
Member
There was a problem hiding this comment.
This will break the current scaletest workflow, as it uses the slim binary.
If the problem is that scaletest imports from coderd, we can instead move or copy those deps.
Member
Author
|
Holding off on this PR as slim scaletest is in use by the scale test suite. Perphaps we can modify the Edit: Logically I feel scaletesting doesn't belong in the slim binary, but the convenience is obvious. Edit 2: It seems that simply eliminating the |
mafredri
force-pushed
the
mafredri/refactor-scaletest
branch
from
September 4, 2023 16:48
7e27734 to
1bc2e5c
Compare
mafredri
marked this pull request as draft
September 4, 2023 16:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes 3 MB when combined with #9483.
Ref: #9380, #9483