Skip to content

refactor(cli): remove scaletest from slim binary - #9485

Closed
mafredri wants to merge 1 commit into
mainfrom
mafredri/refactor-scaletest
Closed

mafredri wants to merge 1 commit into
mainfrom
mafredri/refactor-scaletest

Conversation

@mafredri

@mafredri mafredri commented Sep 1, 2023

Copy link
Copy Markdown
Member

This change removes 3 MB when combined with #9483.

Ref: #9380, #9483

❯ ls -lha build
total 2.3G
drwxr-xr-x  2 coder coder 4.0K Sep  1 13:23 ./
drwxr-xr-x 30 coder coder 4.0K Sep  1 13:19 ../
-rw-r--r--  1 coder coder 366M Sep  1 13:21 coder-slim_2.1.4-devel+2089ddad8.tar
-rw-r--r--  1 coder coder  99M Sep  1 13:21 coder-slim_2.1.4-devel+2089ddad8.tar.zst
-rw-r--r--  1 coder coder  434 Sep  1 13:21 coder-slim_2.1.4-devel+2089ddad8_checksums.sha1
-rwxr-xr-x  1 coder coder  53M Sep  1 13:20 coder-slim_2.1.4-devel+2089ddad8_darwin_amd64*
-rwxr-xr-x  1 coder coder  53M Sep  1 13:20 coder-slim_2.1.4-devel+2089ddad8_darwin_arm64*
-rwxr-xr-x  1 coder coder  57M Sep  1 13:20 coder-slim_2.1.4-devel+2089ddad8_linux_amd64*
-rwxr-xr-x  1 coder coder  55M Sep  1 13:20 coder-slim_2.1.4-devel+2089ddad8_linux_arm64*
-rwxr-xr-x  1 coder coder  54M Sep  1 13:20 coder-slim_2.1.4-devel+2089ddad8_linux_armv7*
-rwxr-xr-x  1 coder coder  49M Sep  1 13:21 coder-slim_2.1.4-devel+2089ddad8_windows_amd64.exe*
-rwxr-xr-x  1 coder coder  47M Sep  1 13:21 coder-slim_2.1.4-devel+2089ddad8_windows_arm64.exe*
-rwxr-xr-x  1 coder coder 218M Sep  1 13:22 coder_2.1.4-devel+2089ddad8_darwin_amd64*
-rwxr-xr-x  1 coder coder 219M Sep  1 13:22 coder_2.1.4-devel+2089ddad8_darwin_arm64*
-rwxr-xr-x  1 coder coder 220M Sep  1 13:21 coder_2.1.4-devel+2089ddad8_linux_amd64*
-rwxr-xr-x  1 coder coder 216M Sep  1 13:21 coder_2.1.4-devel+2089ddad8_linux_arm64*
-rwxr-xr-x  1 coder coder 215M Sep  1 13:22 coder_2.1.4-devel+2089ddad8_linux_armv7*
-rwxr-xr-x  1 coder coder 212M Sep  1 13:22 coder_2.1.4-devel+2089ddad8_windows_amd64.exe*
-rwxr-xr-x  1 coder coder 209M Sep  1 13:23 coder_2.1.4-devel+2089ddad8_windows_arm64.exe*

@mafredri mafredri self-assigned this Sep 1, 2023
@mafredri
mafredri requested a review from kylecarbs September 1, 2023 13:25
@mafredri
mafredri force-pushed the mafredri/refactor-scaletest branch 2 times, most recently from a02bebd to 7e27734 Compare September 1, 2023 13:42

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the current scaletest workflow, as it uses the slim binary.

If the problem is that scaletest imports from coderd, we can instead move or copy those deps.

@mafredri

mafredri commented Sep 1, 2023 •

Copy link
Copy Markdown
Member Author

Holding off on this PR as slim scaletest is in use by the scale test suite. Perphaps we can modify the coderd/tracing import instead.

Edit: Logically I feel scaletesting doesn't belong in the slim binary, but the convenience is obvious.

Edit 2: It seems that simply eliminating the coderd/tracing import reduces the size with 2MB instead of 3MB, so that was the main win in removing the scaletest command.

This change removes 3 MB when combined with #9483.

Ref: #9380, #9483
@mafredri
mafredri force-pushed the mafredri/refactor-scaletest branch from 7e27734 to 1bc2e5c Compare September 4, 2023 16:48
@mafredri
mafredri marked this pull request as draft September 4, 2023 16:49
@github-actions github-actions Bot added the stale This issue is like stale bread. label Sep 12, 2023
@github-actions github-actions Bot closed this Sep 15, 2023
@github-actions
github-actions Bot deleted the mafredri/refactor-scaletest branch March 5, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This issue is like stale bread.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants