Skip to content

refactor(cli): avoid importing coderd in slim server - #9483

Merged
mafredri merged 2 commits into
mainfrom
mafredri/refactor-cli-server
Sep 1, 2023
Merged

mafredri merged 2 commits into
mainfrom
mafredri/refactor-cli-server

Conversation

@mafredri

@mafredri mafredri commented Sep 1, 2023

Copy link
Copy Markdown
Member

This small change removes 11 MB from the slim binary size.

Ref: #9380

❯ ls -lha build
total 2.4G
drwxr-xr-x  2 coder coder 4.0K Sep  1 12:46 ./
drwxr-xr-x 30 coder coder 4.0K Sep  1 12:44 ../
-rw-r--r--  1 coder coder 380M Sep  1 12:45 coder-slim_2.1.4-devel+279f4a4aa.tar
-rw-r--r--  1 coder coder 103M Sep  1 12:45 coder-slim_2.1.4-devel+279f4a4aa.tar.zst
-rw-r--r--  1 coder coder  434 Sep  1 12:45 coder-slim_2.1.4-devel+279f4a4aa_checksums.sha1
-rwxr-xr-x  1 coder coder  56M Sep  1 12:45 coder-slim_2.1.4-devel+279f4a4aa_darwin_amd64*
-rwxr-xr-x  1 coder coder  56M Sep  1 12:45 coder-slim_2.1.4-devel+279f4a4aa_darwin_arm64*
-rwxr-xr-x  1 coder coder  59M Sep  1 12:44 coder-slim_2.1.4-devel+279f4a4aa_linux_amd64*
-rwxr-xr-x  1 coder coder  56M Sep  1 12:45 coder-slim_2.1.4-devel+279f4a4aa_linux_arm64*
-rwxr-xr-x  1 coder coder  56M Sep  1 12:45 coder-slim_2.1.4-devel+279f4a4aa_linux_armv7*
-rwxr-xr-x  1 coder coder  51M Sep  1 12:45 coder-slim_2.1.4-devel+279f4a4aa_windows_amd64.exe*
-rwxr-xr-x  1 coder coder  49M Sep  1 12:45 coder-slim_2.1.4-devel+279f4a4aa_windows_arm64.exe*
-rwxr-xr-x  1 coder coder 223M Sep  1 12:46 coder_2.1.4-devel+279f4a4aa_darwin_amd64*
-rwxr-xr-x  1 coder coder 223M Sep  1 12:46 coder_2.1.4-devel+279f4a4aa_darwin_arm64*
-rwxr-xr-x  1 coder coder 224M Sep  1 12:45 coder_2.1.4-devel+279f4a4aa_linux_amd64*
-rwxr-xr-x  1 coder coder 220M Sep  1 12:45 coder_2.1.4-devel+279f4a4aa_linux_arm64*
-rwxr-xr-x  1 coder coder 219M Sep  1 12:45 coder_2.1.4-devel+279f4a4aa_linux_armv7*
-rwxr-xr-x  1 coder coder 216M Sep  1 12:46 coder_2.1.4-devel+279f4a4aa_windows_amd64.exe*
-rwxr-xr-x  1 coder coder 213M Sep  1 12:46 coder_2.1.4-devel+279f4a4aa_windows_arm64.exe*

This small change removes 11 MB from the slim binary size.

Ref: #9380
@mafredri mafredri self-assigned this Sep 1, 2023
@mafredri
mafredri requested a review from kylecarbs September 1, 2023 12:47

@kylecarbs kylecarbs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool

@mafredri
mafredri force-pushed the mafredri/refactor-cli-server branch from 5d6098d to 28324ae Compare September 1, 2023 12:59
@mafredri
mafredri enabled auto-merge (squash) September 1, 2023 13:30
@mafredri
mafredri merged commit f1f9cb0 into main Sep 1, 2023
@mafredri
mafredri deleted the mafredri/refactor-cli-server branch September 1, 2023 13:32
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants