Skip to content

refactor(coderd/httpapi): remove database, dbauthz and rbac imports - #9481

Merged
mafredri merged 2 commits into
mainfrom
mafredri/refactor-coderd-httpapi
Sep 4, 2023
Merged

mafredri merged 2 commits into
mainfrom
mafredri/refactor-coderd-httpapi

Conversation

@mafredri

@mafredri mafredri commented Sep 1, 2023

Copy link
Copy Markdown
Member

Ref: #9380

No size change (yet), this prevents the agent http API from pulling database and parts of coderd.

❯ make build/coder-slim_linux_amd64
/home/coder/src/coder/coder/build/coder-slim_2.1.4-devel+2baf3504a_linux_amd64

❯ ls -lha /home/coder/src/coder/coder/build/coder-slim_2.1.4-devel+2baf3504a_linux_amd64
-rwxr-xr-x 2 coder coder 70M Sep  1 11:28 /home/coder/src/coder/coder/build/coder-slim_2.1.4-devel+2baf3504a_linux_amd64*

@mafredri mafredri self-assigned this Sep 1, 2023
@mafredri
mafredri requested a review from Emyrk September 1, 2023 11:29
@mafredri
mafredri force-pushed the mafredri/refactor-coderd-httpapi branch from 2baf350 to c67c96e Compare September 1, 2023 11:32
@mafredri
mafredri force-pushed the mafredri/refactor-coderd-httpapi branch from c67c96e to 2aa7372 Compare September 1, 2023 11:49
mafredri added a commit that referenced this pull request Sep 4, 2023
…password command

This change removes 1 MB from the slim binary, and combined with the
following PRs: #9481, #9506, #9508, #9517, a total of 4 MB.

Ref: #9380
mafredri added a commit that referenced this pull request Sep 4, 2023
This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380
mafredri added a commit that referenced this pull request Sep 4, 2023
This is an alternative approach to #9519 and removes 2 MB instead of 1
MB (1.2 MB accounted for by embedded migration SQL files).

Combined with #9481, #9506, #9508, #9517, a total of 5 MB is removed.

Ref: #9380
@mafredri
mafredri merged commit 6fc1f52 into main Sep 4, 2023
@mafredri
mafredri deleted the mafredri/refactor-coderd-httpapi branch September 4, 2023 16:39
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants