Skip to content

ci: Don't run PostgreSQL tests in parallel#94

Merged
kylecarbs merged 1 commit intomainfrom
pgonce
Jan 30, 2022
Merged

ci: Don't run PostgreSQL tests in parallel#94
kylecarbs merged 1 commit intomainfrom
pgonce

Conversation

@kylecarbs
Copy link
Copy Markdown
Member

@kylecarbs kylecarbs commented Jan 30, 2022 •
edited
Loading

There have been race conditions when multiple instances
are created at once. This is an attempt to fix!

There's an ipv4 and ipv6 conflict that can occur in Docker. We'll reduce the Go test parallel count back to 1 until we get time to investigate. See: moby/moby#42442

@kylecarbs kylecarbs self-assigned this Jan 30, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2022 •
edited
Loading

Codecov Report

Merging #94 (346dcbc) into main (5367d93) will decrease coverage by 6.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   78.30%   71.87%   -6.44%     
==========================================
  Files          51       89      +38     
  Lines         507     3612    +3105     
  Branches       55       55              
==========================================
+ Hits          397     2596    +2199     
- Misses         97      793     +696     
- Partials       13      223     +210
Flag Coverage Δ
unittest-go-macos-latest 67.56% <ø> (?)
unittest-go-ubuntu-latest 70.08% <ø> (?)
unittest-go-windows-latest 67.46% <ø> (?)
unittest-js 78.30% <ø> (ø)
Impacted Files Coverage Δ
database/postgres/postgres.go 70.00% <0.00%> (ø)
codersdk/workspaces.go 73.95% <0.00%> (ø)
coderd/users.go 61.63% <0.00%> (ø)
codersdk/users.go 55.40% <0.00%> (ø)
database/pubsub.go 77.08% <0.00%> (ø)
coderd/cmd/root.go 85.71% <0.00%> (ø)
coderd/projects.go 67.32% <0.00%> (ø)
site/embed.go 72.31% <0.00%> (ø)
httpmw/workspaceparam.go 76.47% <0.00%> (ø)
httpmw/apikey.go 84.34% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5367d93...346dcbc. Read the comment docs.

bryphe-coder
bryphe-coder approved these changes Jan 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing this out @kylecarbs !

@kylecarbs
ci: Lock PostgreSQL database creation
346dcbc 
There have been race conditions when multiple instances
are created at once. This is an attempt to fix!
@kylecarbs kylecarbs changed the title ci: Lock PostgreSQL database creation ci: Don't run PostgreSQL tests in parallel Jan 30, 2022
@kylecarbs kylecarbs merged commit a7d6f4b into main Jan 30, 2022
@kylecarbs kylecarbs deleted the pgonce branch January 30, 2022 03:16
@DanielleMaywood DanielleMaywood mentioned this pull request Mar 27, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bryphe-coder bryphe-coder bryphe-coder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kylecarbs kylecarbs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kylecarbs @bryphe-coder