Skip to content

refactor(cli)!: move scaletest to exp/scaletest - #8339

Merged
johnstcn merged 2 commits into
mainfrom
cj/scaletest-exp
Jul 7, 2023
Merged

johnstcn merged 2 commits into
mainfrom
cj/scaletest-exp

Conversation

@johnstcn

@johnstcn johnstcn commented Jul 6, 2023 •

Copy link
Copy Markdown
Member
  • Creates a new hidden exp subcommand
  • Moves the scaletest commands under exp
  • Updates existing invocations

Fixes #7856

@johnstcn johnstcn self-assigned this Jul 6, 2023
@johnstcn johnstcn changed the title refactor(cli): mv scaletest exp/scaletest refactor(cli): move scaletest to exp/scaletest Jul 6, 2023
@johnstcn
johnstcn requested review from mafredri and mtojek July 6, 2023 14:09
@johnstcn
johnstcn marked this pull request as ready for review July 6, 2023 14:09

@mafredri mafredri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mafredri

mafredri commented Jul 6, 2023

Copy link
Copy Markdown
Member

Should we mark this breaking since we're moving a non-exp command?

@johnstcn johnstcn changed the title refactor(cli): move scaletest to exp/scaletest refactor(cli)!: move scaletest to exp/scaletest Jul 6, 2023
@github-actions github-actions Bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Jul 6, 2023
@johnstcn

johnstcn commented Jul 6, 2023

Copy link
Copy Markdown
Member Author

Should we mark this breaking since we're moving a non-exp command?

I suppose yes, it technically is!

@johnstcn
johnstcn merged commit 435c67a into main Jul 7, 2023
@johnstcn
johnstcn deleted the cj/scaletest-exp branch July 7, 2023 08:10
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release/breaking This label is applied to PRs to detect breaking changes as part of the release process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move scaletest into coder exp

2 participants