Repository navigation
fix(cli)!: protect client Logger and refactor cli scaletest tests #8317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8f07b9b
fix data race in scaletest_test
johnstcn b0b55f9
add TODO
johnstcn f863a83
fillet cli scaletest createworkspaces test, bulk up tests in scaletes…
johnstcn b3d1c6e
make fmt
johnstcn 9fb7479
appease the linter
johnstcn a7f7e10
wait for template version before creating template
johnstcn b511f16
unskip scaletest/workspacebuild tests
johnstcn f45f938
add IgnoreErrors option to agent loggers
johnstcn 86c553c
coderd: TestDeploymentStats: make test slightly less time-sensitive
johnstcn d38b6c8
fix potential race in test cleanup
johnstcn 543a8f1
address comments re: RaceEnabled
johnstcn a51dba7
fixup! address comments re: RaceEnabled
johnstcn aaf3829
Merge remote-tracking branch 'origin/main' into cj/scaletest-createwo…
johnstcn 2bcd712
client: make it clear what fields mu protects
johnstcn 61dc5f9
make cleanup nicer
johnstcn efeac86
Merge remote-tracking branch 'origin/main' into cj/scaletest-createwo…
johnstcn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review: already tested in scaletest/createworkspaces/run_test.go. No point duplicating.