feat: Add provisionerd protobuf definitions#83
Merged
Conversation
This modifies a prior migration which is typically forbidden, but because we're pre-production deployment I felt grouping would be helpful to future contributors. This adds database functions that are required for the provisioner daemon and job queue logic.
Adds a projectparameter package to compute build-time project values for a provided scope. This package will be used to return which variables are being used for a build, and can visually indicate the hierarchy to a user.
Provisionerd communicates with coderd over a multiplexed WebSocket serving dRPC. This adds a roughly accurate protocol definition. It shares definitions with "provisioner.proto" for simple interop with provisioners!
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 71.70% 71.45% -0.26%
==========================================
Files 89 89
Lines 3563 3563
Branches 55 55
==========================================
- Hits 2555 2546 -9
- Misses 787 794 +7
- Partials 221 223 +2
Continue to review full report at Codecov.
|
| @@ -1,3 +1,4 @@ | |||
| # Generated files | |||
| peerbroker/proto/*.go linguist-generated=true | |||
| provisionerd/proto/*.go linguist-generated=true | |||
Contributor
There was a problem hiding this comment.
Thanks for adding this 👍
Comment on lines
+6
to
+9
| bin/provisionerd: | ||
| mkdir -p bin | ||
| go build -o bin/provisionerd cmd/provisionerd/main.go | ||
| .PHONY: bin/provisionerd |
Contributor
There was a problem hiding this comment.
Nice! This is a big chunk to get in towards black triangle 🎉
bryphe-coder
approved these changes
Jan 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provisionerd communicates with coderd over a multiplexed
WebSocket serving dRPC. This adds a roughly accurate protocol
definition.
It shares definitions with "provisioner.proto" for simple
interop with provisions!