Skip to content

feat: add advanced schedule settings - #7061

Merged
rodrimaia merged 4 commits into
mainfrom
feat_add_autostop_setting
Apr 12, 2023
Merged

rodrimaia merged 4 commits into
mainfrom
feat_add_autostop_setting

Conversation

@rodrimaia

@rodrimaia rodrimaia commented Apr 10, 2023 •

Copy link
Copy Markdown
Contributor

image

Closes #6047
Closes #6497

@rodrimaia
rodrimaia requested a review from deansheather April 10, 2023 13:15
@rodrimaia rodrimaia self-assigned this Apr 10, 2023
@rodrimaia rodrimaia changed the title ddfeat: add advanced schedule settings feat: add advanced schedule settings Apr 10, 2023
@rodrimaia
rodrimaia requested a review from BrunoQuaresma April 10, 2023 13:36

@BrunoQuaresma BrunoQuaresma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deansheather deansheather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can we change auto-start => autostart and auto-stop to autostop? Sorry if my original diagrams were incorrect but this is what we've settled on now

@rodrimaia
rodrimaia force-pushed the feat_add_autostop_setting branch from bd21474 to f5916cf Compare April 11, 2023 20:31
@BrunoQuaresma

Copy link
Copy Markdown
Contributor

@rodrimaia is just a minor thing. The secondary text of the new checkbox does not match the current style. You can see
an existing one with a smaller secondary text and a more gray color.

Screen Shot 2023-04-12 at 10 12 13

@rodrimaia

Copy link
Copy Markdown
Contributor Author

@rodrimaia is just a minor thing. The secondary text of the new checkbox does not match the current style. You can see an existing one with a smaller secondary text and a more gray color.

Screen Shot 2023-04-12 at 10 12 13

Fixed! thank you for noticing, Bruno! :)

@rodrimaia
rodrimaia enabled auto-merge (squash) April 12, 2023 17:44
@rodrimaia
rodrimaia merged commit d1d459c into main Apr 12, 2023
@rodrimaia
rodrimaia deleted the feat_add_autostop_setting branch April 12, 2023 17:47
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scheduling: Add a toggle in template settings to disable user-controlled shutdown behavior scheduling: advanced scheduling controls

3 participants