Skip to content

feat(site): Support list(string) rich parameter field - #6653

Merged
BrunoQuaresma merged 3 commits into
mainfrom
bq/multi-string-field
Mar 17, 2023
Merged

BrunoQuaresma merged 3 commits into
mainfrom
bq/multi-string-field

Conversation

@BrunoQuaresma

Copy link
Copy Markdown
Contributor

Demo:

Screen.Recording.2023-03-17.at.14.29.36.mov

Close #6582

@BrunoQuaresma
BrunoQuaresma requested review from a team and mtojek March 17, 2023 17:33
@BrunoQuaresma BrunoQuaresma self-assigned this Mar 17, 2023
@BrunoQuaresma
BrunoQuaresma requested review from Kira-Pilot and removed request for a team March 17, 2023 17:33
setParameterValue(value)
onChange(value)
} catch (e) {
console.error("Error on change of list(string) parameter", e)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do anything else with error handling here or on line 165?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we control but in case it gets an error, I added a message to help a bit more.

@BrunoQuaresma
BrunoQuaresma enabled auto-merge (squash) March 17, 2023 18:48
@BrunoQuaresma
BrunoQuaresma merged commit ca067cf into main Mar 17, 2023
@BrunoQuaresma
BrunoQuaresma deleted the bq/multi-string-field branch March 17, 2023 18:53
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rich parameters: support new type list(string)

2 participants