Skip to content

feat!: Validate monotonic numbers for rich parameters - #6046

Merged
mtojek merged 10 commits into
coder:mainfrom
mtojek:5978-support-disk-size
Feb 7, 2023
Merged

mtojek merged 10 commits into
coder:mainfrom
mtojek:5978-support-disk-size

Conversation

@mtojek

@mtojek mtojek commented Feb 6, 2023 •

Copy link
Copy Markdown
Member

Fixes: #5978

This PR extends validation rules with support for monotonic numbers.

Screenshot 2023-02-06 at 15 58 51

Changes:

  • breaking: marking validation properties as optional for /rich-parameters
  • feat: define new DB column validation_monotonic: "increasing" or "decreasing"
  • feat: validate monotonicity in the coderd API
  • feat: site: enable monotonicity validation for numbers
  • fix: wrong API response written to docs

@mtojek mtojek self-assigned this Feb 6, 2023
@mtojek mtojek changed the title feat: Add monotonic number support to rich parameters feat!: Add monotonic number support to rich parameters Feb 6, 2023
@mtojek
mtojek marked this pull request as ready for review February 6, 2023 14:58
@mtojek mtojek changed the title feat!: Add monotonic number support to rich parameters feat!: Validate monotonic numbers for rich parameters Feb 6, 2023
@github-actions github-actions Bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Feb 6, 2023

@kylecarbs kylecarbs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. FE tests are nice too 😍

@mtojek
mtojek merged commit b86bce8 into coder:main Feb 7, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 7, 2023
@bpmct bpmct added this to the Rich Parameters GA milestone Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release/breaking This label is applied to PRs to detect breaking changes as part of the release process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rich parameters: support for disk size

3 participants